Martin (CC council) -- Obviously that change I made to P5/Test/antruntest.xml broke the build. The validation of detest.odd as an ODD file is producing no output, when it should produce quite a few errors. (This is the detest1.log file.) The command being issued and giving us incorrect output is, I think $ ANT_OPTS="-Xss2m -Xmx752m -Djava.awt.headless=true" ant -lib ../Utilities/lib/saxon9he.jar:../Utilities/lib/jing.jar -Dtrang=../Utilities/lib/trang.jar -DdefaultSource=`pwd`/../p5subset.xml -DXSL=/var/lib/jenkins/jobs/TEIP5-Test-dev/workspace/P5/../../../Stylesheets-dev/lastSuccessful/archive/dist/xml/tei/stylesheet -f antruntest.xml -Doutputname=detest -DoddFile=detest.odd validateodd > detest1.log 2>&1 Which is to say run antruntest.xml target validateodd with input detest.odd. When I run the same commandline on my home desktop (slightly different paths, of course), and separate out STDERR from STDOUT, I get no errors and the following detest1.log: | Buildfile: /home/syd/Documents/TEI_dev/P5/Test/antruntest.xml | | validateodd: | | BUILD SUCCESSFUL | Total time: 0 seconds That looks very much like it is not even trying to run validateodd. Any thoughts?
Hi Syd, I checked your changes and see that you introduced a new(?) variable ${DTDcompat} in antruntest.xml which you refer to multiple times. Crucial part is in line https://github.com/TEIC/TEI/blob/c293b6275365b5eefc60399fbec60c7879bc7ee8/P5... where the @unless=„DTDcompat“ blocks the test. One obvious thing is that the variable must be referenced by ${DTDcompat} but I have no idea where you would want to inject the proper value? Best Peter
Am 10.11.2017 um 01:52 schrieb Syd Bauman
: Martin (CC council) --
Obviously that change I made to P5/Test/antruntest.xml broke the build. The validation of detest.odd as an ODD file is producing no output, when it should produce quite a few errors. (This is the detest1.log file.)
The command being issued and giving us incorrect output is, I think $ ANT_OPTS="-Xss2m -Xmx752m -Djava.awt.headless=true" ant -lib ../Utilities/lib/saxon9he.jar:../Utilities/lib/jing.jar -Dtrang=../Utilities/lib/trang.jar -DdefaultSource=`pwd`/../p5subset.xml -DXSL=/var/lib/jenkins/jobs/TEIP5-Test-dev/workspace/P5/../../../Stylesheets-dev/lastSuccessful/archive/dist/xml/tei/stylesheet -f antruntest.xml -Doutputname=detest -DoddFile=detest.odd validateodd > detest1.log 2>&1
Which is to say run antruntest.xml target validateodd with input detest.odd. When I run the same commandline on my home desktop (slightly different paths, of course), and separate out STDERR from STDOUT, I get no errors and the following detest1.log:
| Buildfile: /home/syd/Documents/TEI_dev/P5/Test/antruntest.xml | | validateodd: | | BUILD SUCCESSFUL | Total time: 0 seconds
That looks very much like it is not even trying to run validateodd. Any thoughts?
-- tei-council mailing list tei-council@lists.tei-c.org http://lists.lists.tei-c.org/mailman/listinfo/tei-council
PLEASE NOTE: postings to this list are publicly archived
But, but ... I don't really speak 'ant' very well, but AFAIK DTDcmopat is a property, and it's set (to a boolean) on line 162. What I've read (e.g. https://stackoverflow.com/questions/5643918/if-and-unless-in-ant) shows the property being referenced in an @if or @unless as a Name, not a variable-like-reference. In truth (as the comment on 164 says) the value of DTDcompat should probably be passed in from the caller, defaulting to "true", but set to "false" for tei_customization. (But that's a bit of a pain to do in the Makefile. :-)
I checked your changes and see that you introduced a new(?) variable ${DTDcompat} in antruntest.xml which you refer to multiple times. Crucial part is in line https://github.com/TEIC/TEI/blob/c293b6275365b5eefc60399fbec60c7879bc7ee8/P5... where the @unless=„DTDcompat“ blocks the test. One obvious thing is that the variable must be referenced by ${DTDcompat} but I have no idea where you would want to inject the proper value?
Ah, I see, you’re completely right! But still, when you put @unless=„DTDcompat“ it checks whether the property is set – which is always the case (being true or false). If you want to check for the value, use ${DTDcompat}. But could it be feasible to remove the <condition> statement completely and have the property just passed in (if necessary)? Than the @unless should stay as it is … Best Peter
Am 10.11.2017 um 23:37 schrieb Syd Bauman
: But, but ... I don't really speak 'ant' very well, but AFAIK DTDcmopat is a property, and it's set (to a boolean) on line 162. What I've read (e.g. https://stackoverflow.com/questions/5643918/if-and-unless-in-ant) shows the property being referenced in an @if or @unless as a Name, not a variable-like-reference.
In truth (as the comment on 164 says) the value of DTDcompat should probably be passed in from the caller, defaulting to "true", but set to "false" for tei_customization. (But that's a bit of a pain to do in the Makefile. :-)
I checked your changes and see that you introduced a new(?) variable ${DTDcompat} in antruntest.xml which you refer to multiple times. Crucial part is in line https://github.com/TEIC/TEI/blob/c293b6275365b5eefc60399fbec60c7879bc7ee8/P5... where the @unless=„DTDcompat“ blocks the test. One obvious thing is that the variable must be referenced by ${DTDcompat} but I have no idea where you would want to inject the proper value? -- tei-council mailing list tei-council@lists.tei-c.org http://lists.lists.tei-c.org/mailman/listinfo/tei-council
PLEASE NOTE: postings to this list are publicly archived
I just find the right snippet of documentation, so while I don't fully understand, I have a clue. Whether you use the property name or the reference to it depends on whether you want to test the existence of the property (which I don't) or its value; but you can only do the latter in ant 1.8.0 and later, which is why lots of web pages have examples of the former. (My confusion came from getting info from 2 different sources, which seem to have been based on different versions of ant.) I am running a local build right now, but will fix the Makefile soon. Thanks, Peter!
Ah, I see, you’re completely right!
But still, when you put @unless=„DTDcompat“ it checks whether the property is set – which is always the case (being true or false). If you want to check for the value, use ${DTDcompat}. But could it be feasible to remove the <condition> statement completely and have the property just passed in (if necessary)? Than the @unless should stay as it is …
But more to the point, the @unless is not supposed to be there now that the value of @checkid is set to the variable reference. Will remove it shortly and see what Mr. Jenkins thinks.
Hi Syd, My main thought is that today's a bit busy for digging into the build process, but if everything goes completely according to plan tomorrow, I'll be floating around as a support person all day so I should have time to take a look. :-) See you tomorrow, Martin On 2017-11-09 04:52 PM, Syd Bauman wrote:
Martin (CC council) --
Obviously that change I made to P5/Test/antruntest.xml broke the build. The validation of detest.odd as an ODD file is producing no output, when it should produce quite a few errors. (This is the detest1.log file.)
The command being issued and giving us incorrect output is, I think $ ANT_OPTS="-Xss2m -Xmx752m -Djava.awt.headless=true" ant -lib ../Utilities/lib/saxon9he.jar:../Utilities/lib/jing.jar -Dtrang=../Utilities/lib/trang.jar -DdefaultSource=`pwd`/../p5subset.xml -DXSL=/var/lib/jenkins/jobs/TEIP5-Test-dev/workspace/P5/../../../Stylesheets-dev/lastSuccessful/archive/dist/xml/tei/stylesheet -f antruntest.xml -Doutputname=detest -DoddFile=detest.odd validateodd > detest1.log 2>&1
Which is to say run antruntest.xml target validateodd with input detest.odd. When I run the same commandline on my home desktop (slightly different paths, of course), and separate out STDERR from STDOUT, I get no errors and the following detest1.log:
| Buildfile: /home/syd/Documents/TEI_dev/P5/Test/antruntest.xml | | validateodd: | | BUILD SUCCESSFUL | Total time: 0 seconds
That looks very much like it is not even trying to run validateodd. Any thoughts?
participants (3)
-
Martin Holmes
-
Peter Stadler
-
Syd Bauman