Heading for Release 4.5.0 / 7.54.0
Dear all, the release team (Martina, Sabine and I) had a very productive morning and pulled in some pending pull requests. There are still various pending PRs but we urge you to keep your hands away from the keyboard since we already entered freeze period (i.e. the real freeze, not the hot freeze!) That said, we’d really appreciate your input and review for/of * https://github.com/TEIC/TEI/pull/2359 https://github.com/TEIC/TEI/pull/2359 – Dead iso cat * https://github.com/TEIC/TEI/pull/2342 https://github.com/TEIC/TEI/pull/2342 – measure part of att.ranging * https://github.com/TEIC/Stylesheets/pull/583 https://github.com/TEIC/Stylesheets/pull/583 – update p5subset The first two might get into the release if approved over the weekend; the third is a necessary update of the file p5subset.xml for the Stylesheets tests. Here we need to look through the changes to the expected results and whether they correctly reflect our intentions. The release team scheduled a meeting for Monday (see Google calendar) where we will go through the weekend-fallout. Additionally, we will then move all open issues and PRs from the current milestones to the next. If you already know about unfinished work regarding your tickets, please feel free to move them to the next milestone yourselves. Have a great weekend Peter
Release team — I am the p5subset updater this month. Does this mean you prefer I hold off and instead review a PR that does so? I have to admit, I am not sure what it means to review a PR that just pulls in the subset (and updates tests to match). I mean, there are no changes that can or should be made to the subset, and whether or not it breaks the Stylesheets build, it has to go in. So are you seeking a review of the changes to the expected-results/ files? (I.e., a quick thumbs up if the changes seem to be the result of changes to the subset? ’Cause there really seems to be no point in spending the entire weekend on a detailed examination of 6,400+ changes.) ________________________________ the release team (Martina, Sabine and I) had a very productive morning and pulled in some pending pull requests. There are still various pending PRs but we urge you to keep your hands away from the keyboard since we already entered freeze period (i.e. the real freeze, not the hot freeze!) That said, we’d really appreciate your input and review for/of * https://github.com/TEIC/TEI/pull/2359https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTEIC%2FTEI%2Fpull%2F2359&data=05%7C01%7Cs.bauman%40northeastern.edu%7C2192c7f10d914f48137908dab36a568e%7Ca8eec281aaa34daeac9b9a398b9215e7%7C0%7C0%7C638019568834484782%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000%7C%7C%7C&sdata=uX2CcevgO4B4jCGRpKXePuwz2l2pZ2RRgfmhglSzFVQ%3D&reserved=0 – Dead iso cat * https://github.com/TEIC/TEI/pull/2342https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTEIC%2FTEI%2Fpull%2F2342&data=05%7C01%7Cs.bauman%40northeastern.edu%7C2192c7f10d914f48137908dab36a568e%7Ca8eec281aaa34daeac9b9a398b9215e7%7C0%7C0%7C638019568834484782%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000%7C%7C%7C&sdata=N37d8j3o%2FZ0wh8d%2BgwjlnWEvtKl1501OY4byd3uTIoo%3D&reserved=0 – measure part of att.ranging * https://github.com/TEIC/Stylesheets/pull/583https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTEIC%2FStylesheets%2Fpull%2F583&data=05%7C01%7Cs.bauman%40northeastern.edu%7C2192c7f10d914f48137908dab36a568e%7Ca8eec281aaa34daeac9b9a398b9215e7%7C0%7C0%7C638019568834484782%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000%7C%7C%7C&sdata=pIMVIX90wyYW8pz7Ko4ZXew%2F730y7zI3xJsszgyJ1Ig%3D&reserved=0 – update p5subset The first two might get into the release if approved over the weekend; the third is a necessary update of the file p5subset.xml for the Stylesheets tests. Here we need to look through the changes to the expected results and whether they correctly reflect our intentions. The release team scheduled a meeting for Monday (see Google calendar) where we will go through the weekend-fallout. Additionally, we will then move all open issues and PRs from the current milestones to the next. If you already know about unfinished work regarding your tickets, please feel free to move them to the next milestone yourselves.
Yes to „a quick thumbs up“. I created a PR by pulling in the new p5subset.xml and "fixing“ the tests by simply copying from actual-results to expected results where necessary. So the intellectual task is to check whether these changes (to the expected-results in the PR) are indeed expected or whether they reveal some issues. How would you be doing the task of updating p5subset.xml? Cheers Peter
Am 21.10.2022 um 17:01 schrieb Bauman, Syd
: Release team — I am the p5subset updater this month. Does this mean you prefer I hold off and instead review a PR that does so? I have to admit, I am not sure what it means to review a PR that just pulls in the subset (and updates tests to match). I mean, there are no changes that can or should be made to the subset, and whether or not it breaks the Stylesheets build, it has to go in. So are you seeking a review of the changes to the expected-results/ files? (I.e., a quick thumbs up if the changes seem to be the result of changes to the subset? ’Cause there really seems to be no point in spending the entire weekend on a detailed examination of 6,400+ changes.)
the release team (Martina, Sabine and I) had a very productive morning and pulled in some pending pull requests. There are still various pending PRs but we urge you to keep your hands away from the keyboard since we already entered freeze period (i.e. the real freeze, not the hot freeze!)
That said, we’d really appreciate your input and review for/of * https://github.com/TEIC/TEI/pull/2359 https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTEIC%2FTEI%2Fpull%2F2359&data=05%7C01%7Cs.bauman%40northeastern.edu%7C2192c7f10d914f48137908dab36a568e%7Ca8eec281aaa34daeac9b9a398b9215e7%7C0%7C0%7C638019568834484782%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000%7C%7C%7C&sdata=uX2CcevgO4B4jCGRpKXePuwz2l2pZ2RRgfmhglSzFVQ%3D&reserved=0 – Dead iso cat * https://github.com/TEIC/TEI/pull/2342 https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTEIC%2FTEI%2Fpull%2F2342&data=05%7C01%7Cs.bauman%40northeastern.edu%7C2192c7f10d914f48137908dab36a568e%7Ca8eec281aaa34daeac9b9a398b9215e7%7C0%7C0%7C638019568834484782%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000%7C%7C%7C&sdata=N37d8j3o%2FZ0wh8d%2BgwjlnWEvtKl1501OY4byd3uTIoo%3D&reserved=0 – measure part of att.ranging * https://github.com/TEIC/Stylesheets/pull/583 https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTEIC%2FStylesheets%2Fpull%2F583&data=05%7C01%7Cs.bauman%40northeastern.edu%7C2192c7f10d914f48137908dab36a568e%7Ca8eec281aaa34daeac9b9a398b9215e7%7C0%7C0%7C638019568834484782%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000%7C%7C%7C&sdata=pIMVIX90wyYW8pz7Ko4ZXew%2F730y7zI3xJsszgyJ1Ig%3D&reserved=0 – update p5subset
The first two might get into the release if approved over the weekend; the third is a necessary update of the file p5subset.xml for the Stylesheets tests. Here we need to look through the changes to the expected results and whether they correctly reflect our intentions.
The release team scheduled a meeting for Monday (see Google calendar) where we will go through the weekend-fallout. Additionally, we will then move all open issues and PRs from the current milestones to the next. If you already know about unfinished work regarding your tickets, please feel free to move them to the next milestone yourselves.
_______________________________________________ Tei-council mailing list Tei-council@lists.tei-c.org mailto:Tei-council@lists.tei-c.org http://lists.lists.tei-c.org/mailman/listinfo/tei-council http://lists.lists.tei-c.org/mailman/listinfo/tei-council
Dear all, just a quick update regarding the latest PRs. Thanks to Syd, two of the mentioned PRs could be merged, and thanks to Syd one couldn’t :) Although Piotr invested so much and it's a shame we can't honor this now, the current "Dead iso cat“ PR [1] has still too many open issues (conversations). Piotr addressed all the original requests (update/replace ISOCat links, expand examples) but also did much more – including widening the scope of the att.datcat class and adding a new attribute to it – that Council should review more thoroughly, I believe. At least, I feel not comfortable pulling that in last minute. Hope that is ok with you Best Peter [1] https://github.com/TEIC/TEI/pull/2359
Am 21.10.2022 um 15:43 schrieb Peter Stadler
: Dear all,
the release team (Martina, Sabine and I) had a very productive morning and pulled in some pending pull requests. There are still various pending PRs but we urge you to keep your hands away from the keyboard since we already entered freeze period (i.e. the real freeze, not the hot freeze!)
That said, we’d really appreciate your input and review for/of * https://github.com/TEIC/TEI/pull/2359 https://github.com/TEIC/TEI/pull/2359 – Dead iso cat * https://github.com/TEIC/TEI/pull/2342 https://github.com/TEIC/TEI/pull/2342 – measure part of att.ranging * https://github.com/TEIC/Stylesheets/pull/583 https://github.com/TEIC/Stylesheets/pull/583 – update p5subset
The first two might get into the release if approved over the weekend; the third is a necessary update of the file p5subset.xml for the Stylesheets tests. Here we need to look through the changes to the expected results and whether they correctly reflect our intentions.
The release team scheduled a meeting for Monday (see Google calendar) where we will go through the weekend-fallout. Additionally, we will then move all open issues and PRs from the current milestones to the next. If you already know about unfinished work regarding your tickets, please feel free to move them to the next milestone yourselves.
Have a great weekend Peter
participants (2)
-
Bauman, Syd
-
Peter Stadler