I just realised that the Jenkins build job for OxGarage is not building the correct war-packages since the Makefile (which is used by Jenkins) has gotten out of sync with the Dockerfile (which provides the newer build information). Since we are providing a working OxGarage image at DockerHub (https://hub.docker.com/r/teic/oxgarage/) and since it is linked to the GitHub and updates automatically after every change to the repo, I see no necessity for Jenkins to also build the war-files. While updating the Makefile would be easy, I’m reluctant to maintain *two* build scripts. Hence my proposal to remove the OxGarage build job from our Jenkins and to remove the Makefile from the repo to avoid confusion. Along with the Docker image I propose to provide the war-files (extracted from the Docker image) via the GitHub releases. Comments? Best Peter
Agreed! Cheers, Martin On 2018-07-20 11:03 AM, Peter Stadler wrote:
I just realised that the Jenkins build job for OxGarage is not building the correct war-packages since the Makefile (which is used by Jenkins) has gotten out of sync with the Dockerfile (which provides the newer build information).
Since we are providing a working OxGarage image at DockerHub (https://hub.docker.com/r/teic/oxgarage/) and since it is linked to the GitHub and updates automatically after every change to the repo, I see no necessity for Jenkins to also build the war-files.
While updating the Makefile would be easy, I’m reluctant to maintain *two* build scripts.
Hence my proposal to remove the OxGarage build job from our Jenkins and to remove the Makefile from the repo to avoid confusion. Along with the Docker image I propose to provide the war-files (extracted from the Docker image) via the GitHub releases.
Comments?
Best Peter
ok, more updates to the TEI apps (old) Roma, OxGarage and Jenkins: * I just merged my Jenkins branch "stadlerpeter-dockerize-completely“ into dev which I’m successfully running for some time now. * I’m planning to replace the current tei/jenkins image (created 2(!) years ago by Martin) with an automated build from this dev branch (and remove my stadlerpeter/jenkins) * the oxgarage job got removed from the Jenkins repo, but is still present on the jenkins machines. (It will go away when the Jenkins maintainers remove it or when the Jenkins containers get recreated) * OxGarage is now (and has been for already some time) built by DockerHub (https://hub.docker.com/r/teic/oxgarage/) * I added a OxGarage release at GitHub, added the WAR files to the release and added some information to the Readme on how to obtain these WAR files. My plan is to have a proper repo structure for all three apps, i.e. have a dev and a master branch (with the dev branch being the main branch) and have a Docker repo (under our user teic) linked to these repos and have both dev and master branches automatically built. I’ll try my best to document all this but welcome any testers who can point me at missing and/or erroneous bits. Hope that makes sense in this brevity to you … Best Peter
Am 20.07.2018 um 22:00 schrieb Martin Holmes
: Agreed!
Cheers, Martin
On 2018-07-20 11:03 AM, Peter Stadler wrote:
I just realised that the Jenkins build job for OxGarage is not building the correct war-packages since the Makefile (which is used by Jenkins) has gotten out of sync with the Dockerfile (which provides the newer build information). Since we are providing a working OxGarage image at DockerHub (https://hub.docker.com/r/teic/oxgarage/) and since it is linked to the GitHub and updates automatically after every change to the repo, I see no necessity for Jenkins to also build the war-files. While updating the Makefile would be easy, I’m reluctant to maintain *two* build scripts. Hence my proposal to remove the OxGarage build job from our Jenkins and to remove the Makefile from the repo to avoid confusion. Along with the Docker image I propose to provide the war-files (extracted from the Docker image) via the GitHub releases. Comments? Best Peter
participants (2)
-
Martin Holmes
-
Peter Stadler