two dates are not better than one
When I went to actually nuke data.*.xml, I ran into a problem. There were two that were still referenced in the Guidelines: data.temporal.iso.xml and data.duration.iso.xml from ND.[1] I initially "fixed" this by just changing "data." to "teidata." on those two instances in ND. This broke the build horrifically -- the definitions of various attrs (like att.temporal.when.iso) now had *two* lists of possible values. Took some digging around but I found that the "correct" datatypes (teidata.duration.iso.xml, and teidata.temporal.iso.xml) were (incorrectly, I think) still being referenced from ST. I commented out those references in ST, and the build was back to normal (and matches the prose). So that all seems good. BUT, there is still a problem. This means that there are several validation errors that have now crept in: memberOf points to non-existent att.duration.iso ident points to non-existent att.duration.iso ident points to non-existent att.duration.iso ident points to non-existent att.duration.iso ident points to non-existent att.duration.iso specDesc points to non-existent att.duration.iso I am not quite sure what to do about this. While technically validation problems, they don't (I don't think) actually cause any difficulties when building outputs from the source. So rather than check these changes into dev, I have (with Hugh's help) checked them into a new branch, sydb-endDeprecation_2018-10-01. But we should decide what to do about this soon (measured in hours to days), as the deprecation period is now over. One possibility (that I am leaning towards right now): These errors are generated by the special-purpose validation routine P5/Utilities/validator.xsl, referred to in the Makefile with "Check validity with special-purpose XSL code, looking for bad links etc". We could simply update that code so it "knows" about these particular cases, and does not flag them as errors. But before we even think of that, either a) someone else who builds locally should checkout the sydb-endDeprecation_2018-10-01 branch and check that the build is working. (I only tested validate, html-web, and exemplars, I think.), or b) we'll have to ask MH or PS to set up a Jenkins job for this branch. (Seems like overkill to me.) Note-for-Vanessa ---------------- [1] The vast majority of the source files to Guidelines chapters are each stored in an XML file that starts with a 2-letter code. Thus I am using "ND" as shorthand for .../P5/Source/Guidelines/en/ND-NamesDates.xml where "..." is wherever on your system you keep the TEIC/TEI git repo. The chapter files are: * AB-About.xml * AI-AnalyticMechanisms.xml * CC-LanguageCorpora.xml * CE-CertaintyResponsibility.xml * CH-LanguagesCharacterSets.xml * CO-CoreElements.xml * DI-PrintDictionaries.xml * DR-PerformanceTexts.xml * DS-DefaultTextStructure.xml * FS-FeatureStructures.xml * FT-TablesFormulaeGraphics.xml * GD-GraphsNetworksTrees.xml * HD-Header.xml * MS-ManuscriptDescription.xml * ND-NamesDates.xml * NH-Non-hierarchical.xml * PH-PrimarySources.xml * SA-LinkingSegmentationAlignment.xml * SG-GentleIntroduction.xml * ST-Infrastructure.xml * TC-CriticalApparatus.xml * TD-DocumentationElements.xml * TS-TranscriptionsofSpeech.xml * USE.xml * VE-Verse.xml * WD-NonStandardCharacters.xml
Hi Syd, I just ran a build of your branch locally (make clean test html-web) and it worked. But ref-att.duration.iso.html is indeed missing from the Guidelines pages, and although it's referenced from ref-att.duration.html, the reference is not linked (presumably because the page isn't there). I'm not sure what happened to att.duration.iso -- is it supposed to be removed, and we're just looking at cleanup from that removal, or is it being excluded by accident somehow? Do we have a Stylesheets group meeting tomorrow morning? I have it in my calendar, but I'm on vacation so if we don't, I'd rather not get up at the crack of dawn. Cheers, Martin On 2018-10-01 02:04 PM, s.bauman@northeastern.edu wrote:
When I went to actually nuke data.*.xml, I ran into a problem. There were two that were still referenced in the Guidelines: data.temporal.iso.xml and data.duration.iso.xml from ND.[1] I initially "fixed" this by just changing "data." to "teidata." on those two instances in ND. This broke the build horrifically -- the definitions of various attrs (like att.temporal.when.iso) now had *two* lists of possible values. Took some digging around but I found that the "correct" datatypes (teidata.duration.iso.xml, and teidata.temporal.iso.xml) were (incorrectly, I think) still being referenced from ST.
I commented out those references in ST, and the build was back to normal (and matches the prose). So that all seems good. BUT, there is still a problem. This means that there are several validation errors that have now crept in: memberOf points to non-existent att.duration.iso ident points to non-existent att.duration.iso ident points to non-existent att.duration.iso ident points to non-existent att.duration.iso ident points to non-existent att.duration.iso specDesc points to non-existent att.duration.iso
I am not quite sure what to do about this. While technically validation problems, they don't (I don't think) actually cause any difficulties when building outputs from the source.
So rather than check these changes into dev, I have (with Hugh's help) checked them into a new branch, sydb-endDeprecation_2018-10-01.
But we should decide what to do about this soon (measured in hours to days), as the deprecation period is now over.
One possibility (that I am leaning towards right now):
These errors are generated by the special-purpose validation routine P5/Utilities/validator.xsl, referred to in the Makefile with "Check validity with special-purpose XSL code, looking for bad links etc". We could simply update that code so it "knows" about these particular cases, and does not flag them as errors.
But before we even think of that, either
a) someone else who builds locally should checkout the sydb-endDeprecation_2018-10-01 branch and check that the build is working. (I only tested validate, html-web, and exemplars, I think.), or
b) we'll have to ask MH or PS to set up a Jenkins job for this branch. (Seems like overkill to me.)
Note-for-Vanessa ---------------- [1] The vast majority of the source files to Guidelines chapters are each stored in an XML file that starts with a 2-letter code. Thus I am using "ND" as shorthand for .../P5/Source/Guidelines/en/ND-NamesDates.xml where "..." is wherever on your system you keep the TEIC/TEI git repo. The chapter files are: * AB-About.xml * AI-AnalyticMechanisms.xml * CC-LanguageCorpora.xml * CE-CertaintyResponsibility.xml * CH-LanguagesCharacterSets.xml * CO-CoreElements.xml * DI-PrintDictionaries.xml * DR-PerformanceTexts.xml * DS-DefaultTextStructure.xml * FS-FeatureStructures.xml * FT-TablesFormulaeGraphics.xml * GD-GraphsNetworksTrees.xml * HD-Header.xml * MS-ManuscriptDescription.xml * ND-NamesDates.xml * NH-Non-hierarchical.xml * PH-PrimarySources.xml * SA-LinkingSegmentationAlignment.xml * SG-GentleIntroduction.xml * ST-Infrastructure.xml * TC-CriticalApparatus.xml * TD-DocumentationElements.xml * TS-TranscriptionsofSpeech.xml * USE.xml * VE-Verse.xml * WD-NonStandardCharacters.xml
No Stylesheets meeting tomorrow. (We agreed at last Council conference call to sort out when Council meetings will be first, then get Stylesheets group up & running after we know that. Sorry, should have told you, but we were too busy on the Stylesheets release, completely escaped me.) I fixed the missing att.duration.iso thing (thank you). If you get a chance, can you kick off a more thorough build, i.e., including examplars, too? I'll be offline for an hour or so, but expect to check back before turning in. Thanks much.
I just ran a build of your branch locally (make clean test html-web) and it worked. But ref-att.duration.iso.html is indeed missing from the Guidelines pages, and although it's referenced from ref-att.duration.html, the reference is not linked (presumably because the page isn't there).
I'm not sure what happened to att.duration.iso -- is it supposed to be removed, and we're just looking at cleanup from that removal, or is it being excluded by accident somehow?
Do we have a Stylesheets group meeting tomorrow morning? I have it in my calendar, but I'm on vacation so if we don't, I'd rather not get up at the crack of dawn.
My local build now runs with only its usual failures on DTDs and XSDs (which I've never sorted out), plus detest failure (which I will try to look into later tonight). That is, no validation errors at all. So now I'm really worried. (Although I did have to change the namespace prefix on the egXML test from the correct teix: to the incorrect tei: -- I am inclined to change it to "*[local-name() eq 'egXML']" to avoid the problem altogether, but either way a big comment is needed.)
No Stylesheets meeting tomorrow. (We agreed at last Council conference call to sort out when Council meetings will be first, then get Stylesheets group up & running after we know that. Sorry, should have told you, but we were too busy on the Stylesheets release, completely escaped me.)
I fixed the missing att.duration.iso thing (thank you). If you get a chance, can you kick off a more thorough build, i.e., including examplars, too? I'll be offline for an hour or so, but expect to check back before turning in. Thanks much.
Just a reminder that Travis builds every (push to every) branch automatically: https://travis-ci.org/TEIC/TEI/branches By clicking on the respective build # you’ll get the full log. Best Peter
Am 02.10.2018 um 04:04 schrieb Syd Bauman
: My local build now runs with only its usual failures on DTDs and XSDs (which I've never sorted out), plus detest failure (which I will try to look into later tonight). That is, no validation errors at all. So now I'm really worried. (Although I did have to change the namespace prefix on the egXML test from the correct teix: to the incorrect tei: -- I am inclined to change it to "*[local-name() eq 'egXML']" to avoid the problem altogether, but either way a big comment is needed.)
No Stylesheets meeting tomorrow. (We agreed at last Council conference call to sort out when Council meetings will be first, then get Stylesheets group up & running after we know that. Sorry, should have told you, but we were too busy on the Stylesheets release, completely escaped me.)
I fixed the missing att.duration.iso thing (thank you). If you get a chance, can you kick off a more thorough build, i.e., including examplars, too? I'll be offline for an hour or so, but expect to check back before turning in. Thanks much.
Tei-council mailing list Tei-council@lists.tei-c.org http://lists.lists.tei-c.org/mailman/listinfo/tei-council
On 01/10/18 22:04, s.bauman@northeastern.edu wrote:
several validation errors that have now crept in: memberOf points to non-existent att.duration.iso ident points to non-existent att.duration.iso ident points to non-existent att.duration.iso ident points to non-existent att.duration.iso ident points to non-existent att.duration.iso specDesc points to non-existent att.duration.iso
I am not quite sure what to do about this. While technically validation problems, they don't (I don't think) actually cause any difficulties when building outputs from the source.
Find them and fix them?
participants (5)
-
Lou Burnard
-
Martin Holmes
-
Peter Stadler
-
s.bauman@northeastern.edu
-
Syd Bauman