Hy Syd (hold you responsible), I have to admit that this slipped my notice in the last days but now that I do, I believe renaming model.resourceLike to model.resource was a bad idea. There’s even no deprecation for this class so all the customizations will suddenly break (this is how I noticed) for people using this class for e.g. hooking in other stuff … Just wanted to be the first to complain ;) Best Peter
That's a pretty big change, though I imagine at some point, there must have been discussion of how to mitigate the damage? I'm not finding that discussion in the GitHub repo, though... Elisa On Fri, Feb 14, 2020 at 8:42 AM Peter Stadler < pstadler@mail.uni-paderborn.de> wrote:
Hy Syd (hold you responsible),
I have to admit that this slipped my notice in the last days but now that I do, I believe renaming model.resourceLike to model.resource was a bad idea. There’s even no deprecation for this class so all the customizations will suddenly break (this is how I noticed) for people using this class for e.g. hooking in other stuff …
Just wanted to be the first to complain ;)
Best Peter _______________________________________________ Tei-council mailing list Tei-council@lists.tei-c.org http://lists.lists.tei-c.org/mailman/listinfo/tei-council
--
Elisa Beshero-Bondar, PhD
Director, Center for the Digital Text | Associate Professor of English
University of Pittsburgh at Greensburg | Humanities Division
150 Finoli Drive
Greensburg, PA 15601 USA
E-mail: ebb8@pitt.edu
Putting model.resourceLike back and adding a deprecation notice would be
exactly the sort of schema change I think would warrant a 4.0.1 release.
Should we do that?
H
On Fri, Feb 14, 2020 at 8:53 AM Elisa Beshero-Bondar
That's a pretty big change, though I imagine at some point, there must have been discussion of how to mitigate the damage? I'm not finding that discussion in the GitHub repo, though... Elisa
On Fri, Feb 14, 2020 at 8:42 AM Peter Stadler < pstadler@mail.uni-paderborn.de> wrote:
Hy Syd (hold you responsible),
I have to admit that this slipped my notice in the last days but now that I do, I believe renaming model.resourceLike to model.resource was a bad idea. There’s even no deprecation for this class so all the customizations will suddenly break (this is how I noticed) for people using this class for e.g. hooking in other stuff …
Just wanted to be the first to complain ;)
Best Peter _______________________________________________ Tei-council mailing list Tei-council@lists.tei-c.org http://lists.lists.tei-c.org/mailman/listinfo/tei-council
-- Elisa Beshero-Bondar, PhD Director, Center for the Digital Text | Associate Professor of English University of Pittsburgh at Greensburg | Humanities Division 150 Finoli Drive Greensburg, PA 15601 USA E-mail: ebb8@pitt.edu
Development site: http://newtfire.org _______________________________________________ Tei-council mailing list Tei-council@lists.tei-c.org http://lists.lists.tei-c.org/mailman/listinfo/tei-council
I made a first attempt at smoothening that change by readding model.resourceLike: https://github.com/TEIC/TEI/commit/3f12a8314011258eed137bed5b792d39b3139a21 There’s also a Jenkins job for that branch so we can check (and diff) the resulting schemas: https://jenkins-paderborn.tei-c.org/job/TEIP5-branch-pstadler-readd-model.re... This is just to check out the technical possibilities – if it works, we’d need to update the prose and add a deprecation warning. Cheers Peter
Am 14.02.2020 um 15:11 schrieb Hugh Cayless
: Putting model.resourceLike back and adding a deprecation notice would be exactly the sort of schema change I think would warrant a 4.0.1 release. Should we do that?
H
On Fri, Feb 14, 2020 at 8:53 AM Elisa Beshero-Bondar
wrote: That's a pretty big change, though I imagine at some point, there must have been discussion of how to mitigate the damage? I'm not finding that discussion in the GitHub repo, though... Elisa On Fri, Feb 14, 2020 at 8:42 AM Peter Stadler
wrote: Hy Syd (hold you responsible), I have to admit that this slipped my notice in the last days but now that I do, I believe renaming model.resourceLike to model.resource was a bad idea. There’s even no deprecation for this class so all the customizations will suddenly break (this is how I noticed) for people using this class for e.g. hooking in other stuff …
Just wanted to be the first to complain ;)
Best Peter _______________________________________________ Tei-council mailing list Tei-council@lists.tei-c.org http://lists.lists.tei-c.org/mailman/listinfo/tei-council
-- Elisa Beshero-Bondar, PhD Director, Center for the Digital Text | Associate Professor of English University of Pittsburgh at Greensburg | Humanities Division 150 Finoli Drive Greensburg, PA 15601 USA E-mail: ebb8@pitt.edu Development site: http://newtfire.org _______________________________________________ Tei-council mailing list Tei-council@lists.tei-c.org http://lists.lists.tei-c.org/mailman/listinfo/tei-council _______________________________________________ Tei-council mailing list Tei-council@lists.tei-c.org http://lists.lists.tei-c.org/mailman/listinfo/tei-council
Putting model.resourceLike back and adding a deprecation notice would be exactly the sort of schema change I think would warrant a 4.0.1 release. Should we do that?
No! There is no problem, here. We have long held that the rules against "breaking" things apply to transcription documents, not ODDs.
I knew Syd would have an explanation – but still, that change smells like an arbitrary cosmetic modification with not much benefit while breaking *gazillions* of customizations (and that’s just a conservative estimate) Cheers Peter
Am 14.02.2020 um 17:06 schrieb Syd Bauman
: Putting model.resourceLike back and adding a deprecation notice would be exactly the sort of schema change I think would warrant a 4.0.1 release. Should we do that?
No!
There is no problem, here. We have long held that the rules against "breaking" things apply to transcription documents, not ODDs. _______________________________________________ Tei-council mailing list Tei-council@lists.tei-c.org http://lists.lists.tei-c.org/mailman/listinfo/tei-council
participants (5)
-
Elisa Beshero-Bondar
-
Hugh Cayless
-
Peter Stadler
-
Peter Stadler
-
Syd Bauman