Thanks for the reminder, Peter!

Speaking of Stylesheets: I have two open PRs (#356 assigned to Syd and #359 assigned to James) which I believe are not controversial (and tests are passing). Since they address issues raised by the community I’d like to cautiously ask whether these can be approved and still be merged?

That said, there’s probably no need to rush, looking at James’ issue he closed after more than seven years ;)

Suggested code names: a) The Raven (Poe's poem was first published 1945-01-29) b) Rubik's (the Rubik's cube made its debut on 1980-01-29; previously it was a mostly local phenomona called the "Magic Cube") Should the title be "TEI P5 version 3.5.0 and TEI Stylesheets version 7.47.0 release notes" (inserting "TEI" before "Stylesheets")? Plan to look at #1802, #1796, #1757, #1626, #1607 at least, maybe more, after lunch.

I added some more release notes. Please have a look at them and modify/add/comment.

Issues that are currently not in the TEI release notes (see the reasons in brackets): #1840 (concerns the website) #1831, #1806, #1799, #1746, #1693, #1663, #1641, #1617 (closed without implementing) #1802, #1796, #1757, #1626, #1607 (wasn't sure about them) #1645, #1596 (the issues are already in the current release, but weren't closed before) Please add any of these, if you think they should go into the release notes.

I changed the title of the release notes to "TEI P5 version 3.5.0 and Stylesheets version 7.47.0 release notes" and added a few Stylesheets release notes after the TEI release notes - but would ask you to help with this. See milestone: https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%...

Syd, thanks for looking into this! But you haven’t merged it yet (this does not happen automatically after a positive review) — you have to do this explicitly. So we’ll have to wait a little bit more for the magic of famous last words to occur :) Best Peter

Am 24.01.2019 um 18:24 schrieb Syd Bauman :

Re: Freeze violation?

I pulled in Peter's request, possibly violating the freeze (since I'm not entirely sure what the freeze means for the Stylesheets, or if the release techs had created new branch yet or not).

Since the code change only affects the bin/transformtei program, thus probably won't affect building TEI Guidelines (pasts my local build -- hope those aren't famous last words), and is ridiculously easy to back out (Peter added ~15 characters changing only 2 lines of code), I went ahead and pulled it in.

...

Thanks for the reminder, Peter!

---

Tei-council mailing list Tei-council@lists.tei-c.org http://lists.lists.tei-c.org/mailman/listinfo/tei-council

Thank you!

Am 24.01.2019 um 20:15 schrieb Syd Bauman :

But I thought I did... Immediately after giving the positive review, I clicked on the merge button, and was confronted with three choices as to how to do the merge. I (almost randomly) picked one.

But wait! I see now that clicking on that did not cause it to merge, but rather to put up a "confirm merge" question ... OK, just confirmed it now. Sigh. Thanks again, Peter.

...

thanks for looking into this! But you haven’t merged it yet (this does not happen automatically after a positive review) — you have to do this explicitly. So we’ll have to wait a little bit more for the magic of famous last words to occur :)

---

Tei-council mailing list Tei-council@lists.tei-c.org http://lists.lists.tei-c.org/mailman/listinfo/tei-council