
I've just changed all <rng:ref>s referring to "data.DUCK" into <dataRef>s referring to "teidata.DUCK" in P5/Test/detest.odd in the sydb-noSchematron1.x branch. Two questions. 1) For most of these, I wrote the test, and I know it is supposed to be updated. But for the <elementSpec> for the <l> element, there were almost 20 cases <rng:ref key="data.DUCK"/>, and I'm not entirely clear on what is being tested. I'm guessing they should be updated, but someone please tell me or revert them if, e.g., they were there to check that a warning would be generated. 2) I made this change in sydb-noSchematron1.x, because that's what I'm working on, and that detest.odd needed to be updated to test new stuff there. But this is a change we probably want propagated into the dev branch. How do I cherry-pick that one file to be merged from sydb-noSchematron1.x into dev? And one issue: * We should probably develop some guidelines for writing tests in there. I had a bit of a hard time figuring out what the tests I wrote a few years ago supposed to do, and they have comments. Most of the tests have no explanation whatsoever. That's bad.

Sfaics, these changes were already made in the dev branch (by Hugh on Nov 6th). Looks like your branch needs updating? On 11/11/16 20:14, Syd Bauman wrote:
I've just changed all <rng:ref>s referring to "data.DUCK" into <dataRef>s referring to "teidata.DUCK" in P5/Test/detest.odd in the sydb-noSchematron1.x branch. Two questions.
1) For most of these, I wrote the test, and I know it is supposed to be updated. But for the <elementSpec> for the <l> element, there were almost 20 cases <rng:ref key="data.DUCK"/>, and I'm not entirely clear on what is being tested. I'm guessing they should be updated, but someone please tell me or revert them if, e.g., they were there to check that a warning would be generated.
2) I made this change in sydb-noSchematron1.x, because that's what I'm working on, and that detest.odd needed to be updated to test new stuff there. But this is a change we probably want propagated into the dev branch. How do I cherry-pick that one file to be merged from sydb-noSchematron1.x into dev?
And one issue:
* We should probably develop some guidelines for writing tests in there. I had a bit of a hard time figuring out what the tests I wrote a few years ago supposed to do, and they have comments. Most of the tests have no explanation whatsoever. That's bad.
participants (2)
-
Lou Burnard
-
Syd Bauman