att.global.source branch for issue #536
Hiya, I believe I've done the schema-related changes for release-blocking issue #536 (there are still bits of prose to change). Since this was adding a @source attribute in a new global class I did the various changes in a branch. I've not done anything about the testing which I'm sure the changes to classes (att.source and att.readFrom) will break. (But then again, I've never understood the testing and expected results as well as I should.) I'd appreciate someone looking at the changes and seeing if you see anything I've forgotten to do (other than prose updates in the chapters), and also to give me some advice on merging the branch in (or go ahead and do it if it looks good) and/or fixing the needed tests. See most recent change at https://github.com/TEIC/TEI/tree/att.global.source namely https://github.com/TEIC/TEI/commit/69d00eb5b1f762eded61ad836a723c4ad0e4bc5d This changes 37 files with 96 additions and 119 deletions github tells me. -James -- Dr James Cummings, James.Cummings@it.ox.ac.uk Academic IT Services, University of Oxford
I am *finally* making progress with @minOccurs and @maxOccurs after banging my forehead against the wall for ~9 hours (by throwing all my changes out and starting again), so I may well have time to look into this tomorrow. (There are several other things to be done, too.) Not all that facile with this stuff myself, but willing to give it a go.
I believe I've done the schema-related changes for release-blocking issue #536 (there are still bits of prose to change). Since this was adding a @source attribute in a new global class I did the various changes in a branch. I've not done anything about the testing which I'm sure the changes to classes (att.source and att.readFrom) will break. (But then again, I've never understood the testing and expected results as well as I should.) I'd appreciate someone looking at the changes and seeing if you see anything I've forgotten to do (other than prose updates in the chapters), and also to give me some advice on merging the branch in (or go ahead and do it if it looks good) and/or fixing the needed tests.
See most recent change at https://github.com/TEIC/TEI/tree/att.global.source namely https://github.com/TEIC/TEI/commit/69d00eb5b1f762eded61ad836a723c4ad0e4bc5d This changes 37 files with 96 additions and 119 deletions github tells me.
Why is this release blocking? We have been getting along quite well without a global @source for ages. Seems to me that if the prose isn't written and the testing hasn't been done then this isn't going to be ready for the next release. No big deal imho. Sent from my Honor Mobile -------- Original Message -------- Subject: [tei-council] att.global.source branch for issue #536 From: James Cummings To: TEI Council CC: Hiya, I believe I've done the schema-related changes for release-blocking issue #536 (there are still bits of prose to change). Since this was adding a @source attribute in a new global class I did the various changes in a branch. I've not done anything about the testing which I'm sure the changes to classes (att.source and att.readFrom) will break. (But then again, I've never understood the testing and expected results as well as I should.) I'd appreciate someone looking at the changes and seeing if you see anything I've forgotten to do (other than prose updates in the chapters), and also to give me some advice on merging the branch in (or go ahead and do it if it looks good) and/or fixing the needed tests. See most recent change at https://github.com/TEIC/TEI/tree/att.global.source namely https://github.com/TEIC/TEI/commit/69d00eb5b1f762eded61ad836a723c4ad0e4bc5d This changes 37 files with 96 additions and 119 deletions github tells me. -James -- Dr James Cummings, James.Cummings@it.ox.ac.uk Academic IT Services, University of Oxford -- tei-council mailing list tei-council@lists.tei-c.org http://lists.lists.tei-c.org/mailman/listinfo/tei-council PLEASE NOTE: postings to this list are publicly archived
Hi all, Just to update, I've added prose to ST chapter on att.global.source (and since att.global.responsibility wasn't mentioned briefly there I added a bit on that in the same section.) See this commit: https://github.com/TEIC/TEI/commit/95fb1d9a86081caf445802f7cb61d87ddd9cd38b I would be very happy to get some more eyes on this and the schema changes below. And I still am not familiar with merging branches and the best way to do this. If some github guru wants to open up a chat (text chat that is, since I'm in a launch conference for the Digital MSS Toolkit here at the Bodleian) and walk me through it I'm willing to try. I do predict below it will break testing. -James On 26/11/16 23:57, James Cummings wrote:
Hiya,
I believe I've done the schema-related changes for release-blocking issue #536 (there are still bits of prose to change). Since this was adding a @source attribute in a new global class I did the various changes in a branch. I've not done anything about the testing which I'm sure the changes to classes (att.source and att.readFrom) will break. (But then again, I've never understood the testing and expected results as well as I should.) I'd appreciate someone looking at the changes and seeing if you see anything I've forgotten to do (other than prose updates in the chapters), and also to give me some advice on merging the branch in (or go ahead and do it if it looks good) and/or fixing the needed tests.
See most recent change at https://github.com/TEIC/TEI/tree/att.global.source namely https://github.com/TEIC/TEI/commit/69d00eb5b1f762eded61ad836a723c4ad0e4bc5d This changes 37 files with 96 additions and 119 deletions github tells me.
-James
-- Dr James Cummings, James.Cummings@it.ox.ac.uk Academic IT Services, University of Oxford
What branches do you want to merge? If you're talking about creating the
pre-release branch, there are step-by-step instructions in
http://teic.github.io/TCW/tcw22.html
On Mon, Nov 28, 2016 at 9:51 AM, James Cummings
Hi all,
Just to update, I've added prose to ST chapter on att.global.source (and since att.global.responsibility wasn't mentioned briefly there I added a bit on that in the same section.)
See this commit: https://github.com/TEIC/TEI/co mmit/95fb1d9a86081caf445802f7cb61d87ddd9cd38b
I would be very happy to get some more eyes on this and the schema changes below.
And I still am not familiar with merging branches and the best way to do this. If some github guru wants to open up a chat (text chat that is, since I'm in a launch conference for the Digital MSS Toolkit here at the Bodleian) and walk me through it I'm willing to try. I do predict below it will break testing.
-James
On 26/11/16 23:57, James Cummings wrote:
Hiya,
I believe I've done the schema-related changes for release-blocking issue #536 (there are still bits of prose to change). Since this was adding a @source attribute in a new global class I did the various changes in a branch. I've not done anything about the testing which I'm sure the changes to classes (att.source and att.readFrom) will break. (But then again, I've never understood the testing and expected results as well as I should.) I'd appreciate someone looking at the changes and seeing if you see anything I've forgotten to do (other than prose updates in the chapters), and also to give me some advice on merging the branch in (or go ahead and do it if it looks good) and/or fixing the needed tests.
See most recent change at https://github.com/TEIC/TEI/tr ee/att.global.source namely https://github.com/TEIC/TEI/co mmit/69d00eb5b1f762eded61ad836a723c4ad0e4bc5d This changes 37 files with 96 additions and 119 deletions github tells me.
-James
-- Dr James Cummings, James.Cummings@it.ox.ac.uk Academic IT Services, University of Oxford
-- tei-council mailing list tei-council@lists.tei-c.org http://lists.lists.tei-c.org/mailman/listinfo/tei-council
PLEASE NOTE: postings to this list are publicly archived
No, I'm suggesting merging the att.global.source branch into dev. I'm assuming because it creates a new global attribute (and removes where it was before -- let me know if I've missed anywhere) that it will break lots of things. (Hence why I don't want to do it without someone else around to help me figure out what has broken. ;-) ) -James On 28/11/16 15:11, Hugh Cayless wrote:
What branches do you want to merge? If you're talking about creating the pre-release branch, there are step-by-step instructions in http://teic.github.io/TCW/tcw22.html
On Mon, Nov 28, 2016 at 9:51 AM, James Cummings
mailto:James.Cummings@it.ox.ac.uk> wrote: Hi all,
Just to update, I've added prose to ST chapter on att.global.source (and since att.global.responsibility wasn't mentioned briefly there I added a bit on that in the same section.)
See this commit: https://github.com/TEIC/TEI/commit/95fb1d9a86081caf445802f7cb61d87ddd9cd38b https://github.com/TEIC/TEI/commit/95fb1d9a86081caf445802f7cb61d87ddd9cd38b
I would be very happy to get some more eyes on this and the schema changes below.
And I still am not familiar with merging branches and the best way to do this. If some github guru wants to open up a chat (text chat that is, since I'm in a launch conference for the Digital MSS Toolkit here at the Bodleian) and walk me through it I'm willing to try. I do predict below it will break testing.
-James
On 26/11/16 23:57, James Cummings wrote:
Hiya,
I believe I've done the schema-related changes for release-blocking issue #536 (there are still bits of prose to change). Since this was adding a @source attribute in a new global class I did the various changes in a branch. I've not done anything about the testing which I'm sure the changes to classes (att.source and att.readFrom) will break. (But then again, I've never understood the testing and expected results as well as I should.) I'd appreciate someone looking at the changes and seeing if you see anything I've forgotten to do (other than prose updates in the chapters), and also to give me some advice on merging the branch in (or go ahead and do it if it looks good) and/or fixing the needed tests.
See most recent change at https://github.com/TEIC/TEI/tree/att.global.source https://github.com/TEIC/TEI/tree/att.global.source namely https://github.com/TEIC/TEI/commit/69d00eb5b1f762eded61ad836a723c4ad0e4bc5d https://github.com/TEIC/TEI/commit/69d00eb5b1f762eded61ad836a723c4ad0e4bc5d This changes 37 files with 96 additions and 119 deletions github tells me.
-James
-- Dr James Cummings, James.Cummings@it.ox.ac.uk mailto:James.Cummings@it.ox.ac.uk Academic IT Services, University of Oxford
-- tei-council mailing list tei-council@lists.tei-c.org mailto:tei-council@lists.tei-c.org http://lists.lists.tei-c.org/mailman/listinfo/tei-council http://lists.lists.tei-c.org/mailman/listinfo/tei-council
PLEASE NOTE: postings to this list are publicly archived
-- Dr James Cummings, James.Cummings@it.ox.ac.uk Academic IT Services, University of Oxford
Have you tried building your branch locally? That would be my first step... On 28/11/16 15:31, James Cummings wrote:
No, I'm suggesting merging the att.global.source branch into dev. I'm assuming because it creates a new global attribute (and removes where it was before -- let me know if I've missed anywhere) that it will break lots of things. (Hence why I don't want to do it without someone else around to help me figure out what has broken. ;-) )
-James
On 28/11/16 15:11, Hugh Cayless wrote:
What branches do you want to merge? If you're talking about creating the pre-release branch, there are step-by-step instructions in http://teic.github.io/TCW/tcw22.html
On Mon, Nov 28, 2016 at 9:51 AM, James Cummings
mailto:James.Cummings@it.ox.ac.uk> wrote: Hi all,
Just to update, I've added prose to ST chapter on att.global.source (and since att.global.responsibility wasn't mentioned briefly there I added a bit on that in the same section.)
See this commit: https://github.com/TEIC/TEI/commit/95fb1d9a86081caf445802f7cb61d87ddd9cd38b https://github.com/TEIC/TEI/commit/95fb1d9a86081caf445802f7cb61d87ddd9cd38b
I would be very happy to get some more eyes on this and the schema changes below.
And I still am not familiar with merging branches and the best way to do this. If some github guru wants to open up a chat (text chat that is, since I'm in a launch conference for the Digital MSS Toolkit here at the Bodleian) and walk me through it I'm willing to try. I do predict below it will break testing.
-James
On 26/11/16 23:57, James Cummings wrote:
Hiya,
I believe I've done the schema-related changes for release-blocking issue #536 (there are still bits of prose to change). Since this was adding a @source attribute in a new global class I did the various changes in a branch. I've not done anything about the testing which I'm sure the changes to classes (att.source and att.readFrom) will break. (But then again, I've never understood the testing and expected results as well as I should.) I'd appreciate someone looking at the changes and seeing if you see anything I've forgotten to do (other than prose updates in the chapters), and also to give me some advice on merging the branch in (or go ahead and do it if it looks good) and/or fixing the needed tests.
See most recent change at https://github.com/TEIC/TEI/tree/att.global.source https://github.com/TEIC/TEI/tree/att.global.source namely https://github.com/TEIC/TEI/commit/69d00eb5b1f762eded61ad836a723c4ad0e4bc5d https://github.com/TEIC/TEI/commit/69d00eb5b1f762eded61ad836a723c4ad0e4bc5d This changes 37 files with 96 additions and 119 deletions github tells me.
-James
-- Dr James Cummings, James.Cummings@it.ox.ac.uk mailto:James.Cummings@it.ox.ac.uk Academic IT Services, University of Oxford
-- tei-council mailing list tei-council@lists.tei-c.org mailto:tei-council@lists.tei-c.org http://lists.lists.tei-c.org/mailman/listinfo/tei-council http://lists.lists.tei-c.org/mailman/listinfo/tei-council
PLEASE NOTE: postings to this list are publicly archived
On 28/11/16 15:40, Lou Burnard wrote:
Have you tried building your branch locally? That would be my first step...
Nope. The laptop I'm on doesn't have a full build environment and dependencies, I don't think. At least when I even try make validate (and point to the checkout of the Stylesheets) I get: /home/jamesc/git/TEI-global-source/P5/antbuilder.xml:186: stylesheet /home/jamesc/git/TEI-global-source/P5/p5odds.isosch.xsl doesn't exist. I've not touched antbuilder.xml or anything to do with schematron in this branch so have no idea what to do after that fatal error. -James
On 28/11/16 15:31, James Cummings wrote:
No, I'm suggesting merging the att.global.source branch into dev. I'm assuming because it creates a new global attribute (and removes where it was before -- let me know if I've missed anywhere) that it will break lots of things. (Hence why I don't want to do it without someone else around to help me figure out what has broken. ;-) )
-James
On 28/11/16 15:11, Hugh Cayless wrote:
What branches do you want to merge? If you're talking about creating the pre-release branch, there are step-by-step instructions in http://teic.github.io/TCW/tcw22.html
On Mon, Nov 28, 2016 at 9:51 AM, James Cummings
mailto:James.Cummings@it.ox.ac.uk> wrote: Hi all,
Just to update, I've added prose to ST chapter on att.global.source (and since att.global.responsibility wasn't mentioned briefly there I added a bit on that in the same section.)
See this commit: https://github.com/TEIC/TEI/commit/95fb1d9a86081caf445802f7cb61d87ddd9cd38b
https://github.com/TEIC/TEI/commit/95fb1d9a86081caf445802f7cb61d87ddd9cd38b
I would be very happy to get some more eyes on this and the schema changes below.
And I still am not familiar with merging branches and the best way to do this. If some github guru wants to open up a chat (text chat that is, since I'm in a launch conference for the Digital MSS Toolkit here at the Bodleian) and walk me through it I'm willing to try. I do predict below it will break testing.
-James
On 26/11/16 23:57, James Cummings wrote:
Hiya,
I believe I've done the schema-related changes for release-blocking issue #536 (there are still bits of prose to change). Since this was adding a @source attribute in a new global class I did the various changes in a branch. I've not done anything about the testing which I'm sure the changes to classes (att.source and att.readFrom) will break. (But then again, I've never understood the testing and expected results as well as I should.) I'd appreciate someone looking at the changes and seeing if you see anything I've forgotten to do (other than prose updates in the chapters), and also to give me some advice on merging the branch in (or go ahead and do it if it looks good) and/or fixing the needed tests.
See most recent change at https://github.com/TEIC/TEI/tree/att.global.source https://github.com/TEIC/TEI/tree/att.global.source namely https://github.com/TEIC/TEI/commit/69d00eb5b1f762eded61ad836a723c4ad0e4bc5d
https://github.com/TEIC/TEI/commit/69d00eb5b1f762eded61ad836a723c4ad0e4bc5d
This changes 37 files with 96 additions and 119 deletions github tells me.
-James
-- Dr James Cummings, James.Cummings@it.ox.ac.uk mailto:James.Cummings@it.ox.ac.uk Academic IT Services, University of Oxford
-- tei-council mailing list tei-council@lists.tei-c.org mailto:tei-council@lists.tei-c.org http://lists.lists.tei-c.org/mailman/listinfo/tei-council http://lists.lists.tei-c.org/mailman/listinfo/tei-council
PLEASE NOTE: postings to this list are publicly archived
-- Dr James Cummings, James.Cummings@it.ox.ac.uk Academic IT Services, University of Oxford
Not sure what you mean by "point to the checkout of the stylesheets". Does your laptop not have the stylesheets installed? What happens if you just type "make clean; make" in your branch? On 28/11/16 15:50, James Cummings wrote:
On 28/11/16 15:40, Lou Burnard wrote:
Have you tried building your branch locally? That would be my first step...
Nope. The laptop I'm on doesn't have a full build environment and dependencies, I don't think.
At least when I even try make validate (and point to the checkout of the Stylesheets) I get:
/home/jamesc/git/TEI-global-source/P5/antbuilder.xml:186: stylesheet /home/jamesc/git/TEI-global-source/P5/p5odds.isosch.xsl doesn't exist.
I've not touched antbuilder.xml or anything to do with schematron in this branch so have no idea what to do after that fatal error.
-James
On 28/11/16 15:31, James Cummings wrote:
No, I'm suggesting merging the att.global.source branch into dev. I'm assuming because it creates a new global attribute (and removes where it was before -- let me know if I've missed anywhere) that it will break lots of things. (Hence why I don't want to do it without someone else around to help me figure out what has broken. ;-) )
-James
On 28/11/16 15:11, Hugh Cayless wrote:
What branches do you want to merge? If you're talking about creating the pre-release branch, there are step-by-step instructions in http://teic.github.io/TCW/tcw22.html
On Mon, Nov 28, 2016 at 9:51 AM, James Cummings
mailto:James.Cummings@it.ox.ac.uk> wrote: Hi all,
Just to update, I've added prose to ST chapter on att.global.source (and since att.global.responsibility wasn't mentioned briefly there I added a bit on that in the same section.)
See this commit: https://github.com/TEIC/TEI/commit/95fb1d9a86081caf445802f7cb61d87ddd9cd38b
https://github.com/TEIC/TEI/commit/95fb1d9a86081caf445802f7cb61d87ddd9cd38b
I would be very happy to get some more eyes on this and the schema changes below.
And I still am not familiar with merging branches and the best way to do this. If some github guru wants to open up a chat (text chat that is, since I'm in a launch conference for the Digital MSS Toolkit here at the Bodleian) and walk me through it I'm willing to try. I do predict below it will break testing.
-James
On 26/11/16 23:57, James Cummings wrote:
Hiya,
I believe I've done the schema-related changes for release-blocking issue #536 (there are still bits of prose to change). Since this was adding a @source attribute in a new global class I did the various changes in a branch. I've not done anything about the testing which I'm sure the changes to classes (att.source and att.readFrom) will break. (But then again, I've never understood the testing and expected results as well as I should.) I'd appreciate someone looking at the changes and seeing if you see anything I've forgotten to do (other than prose updates in the chapters), and also to give me some advice on merging the branch in (or go ahead and do it if it looks good) and/or fixing the needed tests.
See most recent change at https://github.com/TEIC/TEI/tree/att.global.source https://github.com/TEIC/TEI/tree/att.global.source namely https://github.com/TEIC/TEI/commit/69d00eb5b1f762eded61ad836a723c4ad0e4bc5d
https://github.com/TEIC/TEI/commit/69d00eb5b1f762eded61ad836a723c4ad0e4bc5d
This changes 37 files with 96 additions and 119 deletions github tells me.
-James
-- Dr James Cummings, James.Cummings@it.ox.ac.uk mailto:James.Cummings@it.ox.ac.uk Academic IT Services, University of Oxford
-- tei-council mailing list tei-council@lists.tei-c.org mailto:tei-council@lists.tei-c.org http://lists.lists.tei-c.org/mailman/listinfo/tei-council http://lists.lists.tei-c.org/mailman/listinfo/tei-council
PLEASE NOTE: postings to this list are publicly archived
I meant I use XSL=../../Stylesheets to point to the git checkout of the stylesheets. I don't have them installed otherwise on my system (except as part of oxygen framework). but make clean seems to have helped. Now: make validate XSL=../../Stylesheets Ignoring all sorts of schematron warnings I see the following errors: <ERROR>ident points to non-existent model.publicationStmtPart (TEI[1]/text[2]/body[3]/div["HD"]/div["HD2"]/div["HD24"]/specGrp["D2224"]/elementSpec["publicationStmt"]/remarks[9]/p[10]/) </ERROR> <ERROR>ident points to non-existent model.publicationStmtPart (TEI[1]/text[2]/body[3]/div["HD"]/div["HD2"]/div["HD24"]/specGrp["D2224"]/elementSpec["publicationStmt"]/remarks[9]/p[10]/) </ERROR> <ERROR>id 'chicago_15_ed' used more than once</ERROR> oh that id one is my fault...now fixed... I'll push that. I have no idea what the first two are about? I didn't touch anything to do with publicationStmtPart -James On 28/11/16 15:53, Lou Burnard wrote:
Not sure what you mean by "point to the checkout of the stylesheets". Does your laptop not have the stylesheets installed?
What happens if you just type "make clean; make" in your branch?
On 28/11/16 15:50, James Cummings wrote:
On 28/11/16 15:40, Lou Burnard wrote:
Have you tried building your branch locally? That would be my first step...
Nope. The laptop I'm on doesn't have a full build environment and dependencies, I don't think.
At least when I even try make validate (and point to the checkout of the Stylesheets) I get:
/home/jamesc/git/TEI-global-source/P5/antbuilder.xml:186: stylesheet /home/jamesc/git/TEI-global-source/P5/p5odds.isosch.xsl doesn't exist.
I've not touched antbuilder.xml or anything to do with schematron in this branch so have no idea what to do after that fatal error.
-James
On 28/11/16 15:31, James Cummings wrote:
No, I'm suggesting merging the att.global.source branch into dev. I'm assuming because it creates a new global attribute (and removes where it was before -- let me know if I've missed anywhere) that it will break lots of things. (Hence why I don't want to do it without someone else around to help me figure out what has broken. ;-) )
-James
On 28/11/16 15:11, Hugh Cayless wrote:
What branches do you want to merge? If you're talking about creating the pre-release branch, there are step-by-step instructions in http://teic.github.io/TCW/tcw22.html
On Mon, Nov 28, 2016 at 9:51 AM, James Cummings
mailto:James.Cummings@it.ox.ac.uk> wrote: Hi all,
Just to update, I've added prose to ST chapter on att.global.source (and since att.global.responsibility wasn't mentioned briefly there I added a bit on that in the same section.)
See this commit: https://github.com/TEIC/TEI/commit/95fb1d9a86081caf445802f7cb61d87ddd9cd38b
https://github.com/TEIC/TEI/commit/95fb1d9a86081caf445802f7cb61d87ddd9cd38b
I would be very happy to get some more eyes on this and the schema changes below.
And I still am not familiar with merging branches and the best way to do this. If some github guru wants to open up a chat (text chat that is, since I'm in a launch conference for the Digital MSS Toolkit here at the Bodleian) and walk me through it I'm willing to try. I do predict below it will break testing.
-James
On 26/11/16 23:57, James Cummings wrote:
Hiya,
I believe I've done the schema-related changes for release-blocking issue #536 (there are still bits of prose to change). Since this was adding a @source attribute in a new global class I did the various changes in a branch. I've not done anything about the testing which I'm sure the changes to classes (att.source and att.readFrom) will break. (But then again, I've never understood the testing and expected results as well as I should.) I'd appreciate someone looking at the changes and seeing if you see anything I've forgotten to do (other than prose updates in the chapters), and also to give me some advice on merging the branch in (or go ahead and do it if it looks good) and/or fixing the needed tests.
See most recent change at https://github.com/TEIC/TEI/tree/att.global.source https://github.com/TEIC/TEI/tree/att.global.source namely https://github.com/TEIC/TEI/commit/69d00eb5b1f762eded61ad836a723c4ad0e4bc5d
https://github.com/TEIC/TEI/commit/69d00eb5b1f762eded61ad836a723c4ad0e4bc5d
This changes 37 files with 96 additions and 119 deletions github tells me.
-James
-- Dr James Cummings, James.Cummings@it.ox.ac.uk mailto:James.Cummings@it.ox.ac.uk Academic IT Services, University of Oxford
-- tei-council mailing list tei-council@lists.tei-c.org mailto:tei-council@lists.tei-c.org http://lists.lists.tei-c.org/mailman/listinfo/tei-council http://lists.lists.tei-c.org/mailman/listinfo/tei-council
PLEASE NOTE: postings to this list are publicly archived
-- Dr James Cummings, James.Cummings@it.ox.ac.uk Academic IT Services, University of Oxford
On 28/11/16 16:09, James Cummings wrote:
Ignoring all sorts of schematron warnings I see the following errors: <ERROR>ident points to non-existent model.publicationStmtPart (TEI[1]/text[2]/body[3]/div["HD"]/div["HD2"]/div["HD24"]/specGrp["D2224"]/elementSpec["publicationStmt"]/remarks[9]/p[10]/) </ERROR> <ERROR>ident points to non-existent model.publicationStmtPart
Ah, lou points out off list this was a class change after I (re)created this branch. (and is building it on his system) -James -- Dr James Cummings, James.Cummings@it.ox.ac.uk Academic IT Services, University of Oxford
Having finished (I hope) the @minOccurs & @maxOccurs stuff, I woke this morning intending to look at tthis, James. But I see you & Lou are active on it, so holding off for the moment ... speak up when you want more eyes.
I believe I've done the schema-related changes for release-blocking issue #536 (there are still bits of prose to change). Since this was adding a @source attribute in a new global class I did the various changes in a branch. I've not done anything about the testing which I'm sure the changes to classes (att.source and att.readFrom) will break. (But then again, I've never understood the testing and expected results as well as I should.) I'd appreciate someone looking at the changes and seeing if you see anything I've forgotten to do (other than prose updates in the chapters), and also to give me some advice on merging the branch in (or go ahead and do it if it looks good) and/or fixing the needed tests.
See most recent change at https://github.com/TEIC/TEI/tree/att.global.source namely https://github.com/TEIC/TEI/commit/69d00eb5b1f762eded61ad836a723c4ad0e4bc5d This changes 37 files with 96 additions and 119 deletions github tells me.
I think as soon as Lou checks in his changes then more eyes are good. -James On 03/12/16 14:17, Syd Bauman wrote:
Having finished (I hope) the @minOccurs & @maxOccurs stuff, I woke this morning intending to look at tthis, James. But I see you & Lou are active on it, so holding off for the moment ... speak up when you want more eyes.
I believe I've done the schema-related changes for release-blocking issue #536 (there are still bits of prose to change). Since this was adding a @source attribute in a new global class I did the various changes in a branch. I've not done anything about the testing which I'm sure the changes to classes (att.source and att.readFrom) will break. (But then again, I've never understood the testing and expected results as well as I should.) I'd appreciate someone looking at the changes and seeing if you see anything I've forgotten to do (other than prose updates in the chapters), and also to give me some advice on merging the branch in (or go ahead and do it if it looks good) and/or fixing the needed tests.
See most recent change at https://github.com/TEIC/TEI/tree/att.global.source namely https://github.com/TEIC/TEI/commit/69d00eb5b1f762eded61ad836a723c4ad0e4bc5d This changes 37 files with 96 additions and 119 deletions github tells
me.
-- Dr James Cummings, James.Cummings@it.ox.ac.uk Academic IT Services, University of Oxford
participants (4)
-
Hugh Cayless
-
James Cummings
-
Lou Burnard
-
Syd Bauman