Re: [Tei-council] Help? Jenkins doesn't like new unit element

I think I see what I did wrong...I am overdetermining the content of the unit element, and I think I can fix it. If it doesn’t work I’ll write again from the branch. Hoping we can get the unit element in this release. Elisa -- Elisa Beshero-Bondar, PhD Director, Center for the Digital Text Associate Professor of English University of Pittsburgh at Greensburg 150 Finoli Drive, Greensburg, PA 15601 USA E-mail: ebb8@pitt.edu | Development site: http://newtfire.org Typeset by hand on my iPad

On Jul 18, 2018, at 3:03 AM, Elisa Beshero-Bondar wrote:

Greetings, all, I’m stuck on trying to create the new unit element for issue #1461—you probably saw multiple build failures. Jenkins is stable now because I moved my work over to a branch. But I’m hoping someone can help me figure out what I’ve done wrong here! The error messages from Jenkins at this point are simple and repeated, and that makes me think it’s something to do with the content model as I’ve written it in the spec page, but I’m not sure.

Here’s what I’ve done: https://github.com/TEIC/TEI/compare/ebb_unit_element (both the specs page and the Guidelines update)

Here’s the relevant portion of the Jenkins messages:

</Messages> (grep -q "<ERROR>" ValidatorLog.xml;if [ $? -ne 1 ] ; then echo "Oh dear me. ERROR found";diff ValidatorLog.xml expected-results/ValidatorLog.xml;false; fi) sh graphics.sh BUILD: Check validity with nvdl, first examples with feasible validity, and then the valid ones ./run-onvdl p5.nvdl p5.xml /usr/bin/onvdl ./run-onvdl p5valid.nvdl v.xml /usr/bin/onvdl http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:3:48: error: text not allowed here http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:3:55: error: unfinished element "unit": "teix:unit" required to finish the element http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:4:30: error: text not allowed here http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:4:37: error: unfinished element "unit": "teix:unit" required to finish the element http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:4:66: error: text not allowed here http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:4:73: error: unfinished element "unit": "teix:unit" required to finish the element http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:4:17: error: text not allowed here http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:4:24: error: unfinished element "unit": "teix:unit" required to finish the element http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:2:76: error: text not allowed here http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:2:83: error: unfinished element "unit": "teix:unit" required to finish the element http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:3:50: error: text not allowed here http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:3:57: error: unfinished element "unit": "teix:unit" required to finish the element http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:3:47: error: text not allowed here http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:3:54: error: unfinished element "unit": "teix:unit" required to finish the element http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:4:32: error: text not allowed here http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:4:39: error: unfinished element "unit": "teix:unit" required to finish the element http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:4:68: error: text not allowed here http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:4:75: error: unfinished element "unit": "teix:unit" required to finish the element http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:3:48: error: text not allowed here http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:3:55: error: unfinished element "unit": "teix:unit" required to finish the element http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:4:30: error: text not allowed here http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:4:37: error: unfinished element "unit": "teix:unit" required to finish the element http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:4:66: error: text not allowed here http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:4:73: error: unfinished element "unit": "teix:unit" required to finish the element http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:4:17: error: text not allowed here http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:4:24: error: unfinished element "unit": "teix:unit" required to finish the element http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:2:76: error: text not allowed here http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:2:83: error: unfinished element "unit": "teix:unit" required to finish the element http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:3:50: error: text not allowed here http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:3:57: error: unfinished element "unit": "teix:unit" required to finish the element http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:3:47: error: text not allowed here http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:3:54: error: unfinished element "unit": "teix:unit" required to finish the element http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:4:32: error: text not allowed here http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:4:39: error: unfinished element "unit": "teix:unit" required to finish the element http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:4:68: error: text not allowed here http://teijenkins.hcmc.uvic.ca/job/TEIP5-Test-dev/ws/P5/valid/TEI_1-text_1-b...:4:75: error: unfinished element "unit": "teix:unit" required to finish the element Error: nvdl run found problems make: *** [valid] Error 1 Build step 'Execute shell' marked build as failure

Thanks for any help! I’m hoping this looks familiar to someone…

Elisa

-- Elisa Beshero-Bondar, PhD Director, Center for the Digital Text | Associate Professor of English University of Pittsburgh at Greensburg | Humanities Division 150 Finoli Drive Greensburg, PA 15601 USA E-mail: ebb8@pitt.edu Development site: http://newtfire.org

...

On Jul 17, 2018, at 7:51 PM, Elisa wrote:

Hi all— The new unit element has temporarily broken our build, but I just figured out why and will fix tonight when I am back at my desk. We are, I think, just missing a specDesc to include att.lexicographic. I’ll also revisit the ticket to make sure that including these attributes is what we planned.

Elisa

-- Elisa Beshero-Bondar, PhD Director, Center for the Digital Text Associate Professor of English University of Pittsburgh at Greensburg 150 Finoli Drive, Greensburg, PA 15601 USA E-mail: ebb8@pitt.edu | Development site: http://newtfire.org

Typeset by hand on my iPad