Yeah, but that means also putting it back in a bunch of places, and I decided after a while of trying it that there was too high a risk of my making a mistake. I just pushed my change, so we’ll see if it builds ok.
On Oct 14, 2015, at 5:40 , Lou Burnard
wrote: Or you could remove app from model.global, of course. I thought that was what your second choice implied?
On 14/10/15 03:06, Hugh Cayless wrote:
After playing around with this a little, I think a less intrusive fix is to make sure <app>’s content model can’t contain <app>, which is what’s causing the Odd by Example issue. This unfortunately means blowing up <app>’s content model, but it fixes the problem, and will perhaps make it easier to trim it down later on. The downside is a *really* ugly content model.
I’ve also fixed all the Stylesheets tests, as well as a bug I found along the way, and I’ve made it so that P5 version isn’t significant for comparing test output to expected results—meaning just changing the version number won’t break everything. I’m going to try to get this all sorted out tomorrow and aim for a 2.9.1 release, probably on Thursday.
On Oct 13, 2015, at 10:49 , Hugh Cayless
wrote: Yeah, I think it’s a fixable bug, but we ought to do due diligence before whacking it. The need for a fix is urgent though, so I will implement something like model.appLike in a way that we can easily yank it back out if we decide on #1.
On Oct 13, 2015, at 10:30 , Fabio Ciotti
wrote: So I'm not sure the ship has really sailed. Also we've introduced important changes to <rdg> in this release already, so this fix seems small and adequate.
Yes but the changes in <rdg> and <lem> are more permissive while the change n solution one would be restrictive. I do not think that having a look at the examples is enough to draw conclusion on real usage in the community, so either we start a small survey to see if solution 1 (that for me is actually better) doesn't break validity of real existent collections or editions or go with solution 2.
f -- tei-council mailing list tei-council@lists.tei-c.org http://lists.lists.tei-c.org/mailman/listinfo/tei-council
PLEASE NOTE: postings to this list are publicly archived
-- tei-council mailing list tei-council@lists.tei-c.org http://lists.lists.tei-c.org/mailman/listinfo/tei-council
PLEASE NOTE: postings to this list are publicly archived