Done, PR approved. (Despite the mysterious appearance of roughly 70 extra <rng:define>s for various _[@generate] flavors of model class.)
> How would you be doing the task of updating p5subset.xml?
Ummm … in dev branch without a PR, and without asking someone else to do the hard part. (That last is not a serious complaint, BTW … I realize you are working on a release and am happy to have some of the work off-loaded to me. But you did ask.)
Yes to „a quick thumbs up“.
I created a PR by pulling in the new p5subset.xml and "fixing“ the tests by simply copying from actual-results to expected results where necessary. So the intellectual task is to check whether these changes (to the expected-results in the PR) are indeed expected or whether they reveal some issues.
How would you be doing the task of updating p5subset.xml?